Skip to content

Commit

Permalink
handle playlists appearing in top results (closes #524) (#526)
Browse files Browse the repository at this point in the history
* handle playlists appearing in top results #524

parse playlists appearing in top results returning results the same way as for other playlists found be search()

* fixup, add test

---------

Co-authored-by: sigma67 <ytmusicapi@gmail.com>
  • Loading branch information
fischcode and sigma67 authored Jan 21, 2024
1 parent 8831090 commit de651c4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tests/mixins/test_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ def test_search_filters(self, yt_auth):
assert len(results) > 10
assert all(item["resultType"] == "episode" for item in results)

def test_search_top_result(self, yt):
results = yt.search("fdsfsfsd") # issue 524
assert results[0]["category"] == "Top result"
assert results[0]["resultType"] == "playlist"
assert results[0]["playlistId"] == "PLK3q5XTYSK60QH3gDypSu3n9OBz6H9HfV"
assert len(results[0]["author"]) > 0

def test_search_uploads(self, config, yt, yt_oauth):
with pytest.raises(Exception, match="No filter can be set when searching uploads"):
yt.search(
Expand Down
5 changes: 5 additions & 0 deletions ytmusicapi/parsers/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ def parse_top_result(data, search_result_types):
if result_type in ["album"]:
search_result["browseId"] = nav(data, TITLE + NAVIGATION_BROWSE_ID, True)

if result_type in ["playlist"]:
search_result["playlistId"] = nav(data, MENU_PLAYLIST_ID)
search_result["title"] = nav(data, TITLE_TEXT)
search_result["author"] = parse_song_artists_runs(nav(data, ["subtitle", "runs"])[2:])

search_result["thumbnails"] = nav(data, THUMBNAILS, True)
return search_result

Expand Down

0 comments on commit de651c4

Please sign in to comment.