Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prepare tests for Deno #2711

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

wellwelwel
Copy link
Sponsor Collaborator

@wellwelwel wellwelwel commented May 28, 2024

Improving tests interoperability by using:

  • explicit extensions for all test import and require
  • explicit import native Node.js features (such as process, buffer, etc.)
  • use node: prefix for Node.js native features (e.g., node:process, node:buffer, etc.)
  • Use require to import .cjs into .mjs tests

Note

No changes have been made to the main code.


I'm developing a "polyfill" to allow testing CommonJS with Deno directly.
Here's the MySQL2 spoiler:

131/150

Screenshot 2024-05-28 at 12 29 08

The next step depends on wellwelwel/poku#300.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (8f0320d) to head (5f1a5e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2711   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          71       71           
  Lines       15729    15729           
  Branches     1341     1342    +1     
=======================================
  Hits        14208    14208           
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.32% <ø> (ø)
compression-1 90.32% <ø> (ø)
tls-0 89.85% <ø> (ø)
tls-1 90.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review May 28, 2024 20:04
@wellwelwel wellwelwel merged commit acc7993 into sidorares:master May 28, 2024
72 checks passed
@wellwelwel wellwelwel deleted the deno-prepare branch May 28, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant