Use event index from contract instead of local counter #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have our own counter for encrypted txs added to the sequencer contract. Under normal circumstances, this value is the same as the `txIndex` parameter on the TransactionSubmittedEvent. Using the latter is more resistant to reorgs, so we use that now.
fredo
reviewed
Jul 15, 2024
| SELECT event_count FROM transaction_submitted_event_count | ||
| WHERE eon = $1 | ||
| LIMIT 1; | ||
| SELECT max(index) + 1 FROM transaction_submitted_event |
There was a problem hiding this comment.
This should be true with the reorg resistance but could probably be false beforehand
fredo
reviewed
Jul 15, 2024
fredo
approved these changes
Jul 15, 2024
We used to explicitly count the number of txs inserted into the db. This is the value we reset the tx pointer if key generation fails. However, if for some reason, eg due to a reorg, some tx events are missed, this value is a bad choice because the other keypers will likely disagree. Now we use the index of the latest inserted tx instead which is automatically corrected with every new tx, irrespective of what happened in the past.
jannikluhn
force-pushed
the
contract-event-index
branch
from
ad4495e
to
42e7a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.