Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: unify glob_match_with_brace and glob_match #5

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Aug 20, 2024

No description provided.

Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #5 will improve performances by 18.24%

Comparing SyMind:refactor (a84095d) with main (aeaac03)

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark main SyMind:refactor Change
fast-glob 5.2 µs 4.4 µs +18.24%

@SyMind
Copy link
Contributor Author

SyMind commented Aug 20, 2024

@shulaoda Now, its performance when matching expressions without braces surpasses that of glob-match and is similar to fast-glob. However, for expressions with braces, its performance is comparable to glob-match, faster to the main branch of fast-glob.

@shulaoda shulaoda self-assigned this Aug 20, 2024
@shulaoda
Copy link
Owner

Amazing! Thanks!

@shulaoda shulaoda merged commit beb72ad into shulaoda:main Aug 20, 2024
5 checks passed
@SyMind SyMind deleted the refactor branch August 20, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants