Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHOT-4291: Add an app setting to choose between panel or dialog mode #55

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

staceyoue
Copy link
Contributor

@staceyoue staceyoue commented Aug 11, 2023

Original PR created for this: #53

* This was a bandaid slapped on to prevent refreshes while updating
  references (triggered from a menu action)
* Instead ensure that the correct events are emitted (per DCC) such that
  the scene change callback is triggered when necessary
* Alias API has issues with events prior to 2023, so for >= 2023.0 let
  the Alias events trigger the app refresh via the reference update
  actions, and for <2023.0, update the file model manually to refresh
  the app
Copy link
Contributor

@rob-aitchison rob-aitchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks very much!

@RicardoMusch
Copy link
Contributor

Ah great,

Sorry guys, I didn't see the comments on my pr's until now but makes total sense!

Thanks :)

@staceyoue staceyoue merged commit 2133dcb into master Aug 18, 2023
8 checks passed
@staceyoue staceyoue deleted the ticket/SHOT-4291-dialog-mode branch August 18, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants