Add app_display_mode to choose default launch mode (panel or dialog) #42
Conversation
Register engine command from settings instead of hardcoded.
RicardoMusch
requested review from
staceyoue,
barbara-darkshot and
rob-aitchison
as code owners
app.py
Outdated
| ) | ||
|
|
||
| else: | ||
| self.logger.error("An invalid app_display_mode was configured. `{}` is not a valid app_display_mode " |
There was a problem hiding this comment.
Hello @RicardoMusch ,
The CI build pipeline fails because of this two line combination so I have added this snippet from the black hook linter:
self.logger.error(
"An invalid app_display_mode was configured. `{}` is not a valid app_display_mode "
"setting!".format(self.get_setting("app_display_mode"))
)
I could not push this to your forked branch so just wanted to paste it here - thanks!
| @@ -10,6 +10,11 @@ | |||
|
|
|||
| configuration: | |||
|
|
|||
| app_display_mode: | |||
| type: str | |||
There was a problem hiding this comment.
Hi @RicardoMusch ,
Instead of using a string setting here, I'd prefer to use a boolean to switch the display mode (something like the modal mode for tk-multi-publish2)
I think it's safer and should avoid your "else" condition.
There was a problem hiding this comment.
Hello @RicardoMusch , is this one now stale as I see the hard-coded wording instead of the get_setting(display_name) convention from the other PR #44 ?
Also, Barbara's comment is still pending.
Just checking, let us know, thanks!
|
Closing as it is redundant to PR #55 |
This pull request adds an app setting
app_display_modewhich allows us to set how the app launches, in dialog mode or panel mode.The way that a panel spawns in software like Houdini can make it cumbersome to use (the panel spawns collapsed into a sidebar).
If we prefer a dialog this is now possible.