Merge pull request #12 from shinhyo/fix_character_card

fix: sharedElement to card
shinhyo · May 8, 2024 · 69eda79 · 69eda79
2 parents 2aad747 + 2e142cb
commit 69eda79
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/core/designsystem/src/main/java/io/github/shinhyo/brba/core/ui/BrbaCharacterCard.kt b/core/designsystem/src/main/java/io/github/shinhyo/brba/core/ui/BrbaCharacterCard.kt
@@ -60,7 +60,12 @@ fun SharedTransitionScope.BrbaCharacterCard(
         shape = RoundedCornerShape(8.dp),
         modifier = modifier
             .aspectRatio(1f / character.ratio)
-            .clickable { onCharacterClick.invoke(character) },
+            .clickable { onCharacterClick.invoke(character) }
+            .brbaSharedElement(
+                isLocalInspectionMode = LocalInspectionMode.current,
+                animatedVisibilityScope = animatedVisibilityScope,
+                rememberSharedContentState(key = "character_${character.charId}_card"),
+            ),
     ) {
         Box(
             modifier = Modifier
@@ -75,12 +80,7 @@ fun SharedTransitionScope.BrbaCharacterCard(
                     contentDescription = null,
                     contentScale = ContentScale.Crop,
                     modifier = Modifier
-                        .fillMaxSize()
-                        .brbaSharedElement(
-                            isLocalInspectionMode = LocalInspectionMode.current,
-                            animatedVisibilityScope = animatedVisibilityScope,
-                            rememberSharedContentState(key = "character_${character.charId}_card"),
-                        ),
+                        .fillMaxSize(),
                 )
                 Box(
                     modifier = Modifier

diff --git a/gif/0.gif b/gif/0.gif