Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SLEEF_ALWAYS_INLINE as always_inline #537

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Apr 15, 2024

Without it, it can fail to inline leading to performance loss.

Co-Authored-By: Hamlin Li hamlin@rivosinc.com

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@luhenry
Copy link
Contributor Author

luhenry commented Apr 18, 2024

@blapie hi, what would be the path forward for this? Thanks!

@nSircombe
Copy link

Hi @luhenry,
There are a few regular reviewers / approvers away at the moment, this should get addressed in the next week or so, once they're back online.

@luhenry
Copy link
Contributor Author

luhenry commented Apr 18, 2024

@nSircombe sounds good, thank you!

@luhenry
Copy link
Contributor Author

luhenry commented Apr 24, 2024

CI issue is related to microsoft/linux-package-repositories#130

@blapie blapie merged commit 492a2fa into shibatch:master Apr 26, 2024
31 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants