Restructure tests for maintainability and ensure consecutive modified lines are trimmed. Fixes #43. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is to make it easier to modify and extend individual tests without impacting the entire suite. The repeated file loading does slow down the test suite by a factor of about 5, but it's a reasonable small suite so the real impact of this is minimal.
Previously, the test would fail with an unfulfilled promise, with the error description given on stdout. Now the assertion error is caught and passed to done, which gives a nicer output.
…m94#43. At time of commit, these tests fail - only the first line of any block of consecutive modified lines is trimmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test structure used a single sample file as the basis for all tests, which meant that adding a test case that modified the sample file needed changes across all result files to match. This meant it was harder than necessary to add tests, and doing so ran the risk of breaking old tests.
The change does slow down tests due to the constant closing and opening of files, but not very much in real terms (tests still take a few seconds to run).
#43 was caused by the getModifiedLineNumbers function only saving the first line of every "added" block, so only the first line was trimmed.