Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor / future-proof Laravel installation instructions #4135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1000nettles
Copy link

I was running through the Laravel installation docs and stumbled on the step to copy / paste the updated Tailwind config file. I noticed that this overwrites specific properties which are added with the shadcn installation (for example, prefix.) Most importantly, the config to copy / paste no longer adheres to Tailwind config types, specifically:

keyframes: {
        "accordion-down": {
          from: { height: 0 },
          to: { height: "var(--radix-accordion-content-height)" },
        },

height should now be considered a string.

I figured for future proofing it'd just be easiest to instruct on adding back the Laravel-specific properties to the config file.

* This changes the instructions for changing the Tailwind config file after shadcn installation.
* We now instruct on the specific Laravel properties to restore in the config file.
Copy link

vercel bot commented Jun 30, 2024

@1000nettles is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant