Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): Fixed landing page crash (ui.shadcn.com) due to Select/Dropdown/Combobox examples #4097

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

manjushsh
Copy link

@manjushsh manjushsh commented Jun 25, 2024

Changes:

This PR resolves issues:

  1. [bug]: Landing page crashes when examples > forms > account > language selection dropdown clicked. #4096
  2. [bug]: Application error: a client-side exception has occurred on examples > playground page #4102 for both default and new york
  3. [bug]: click combobox in form cause error #4106 for both default and new york

All Test cases passed.

Screenshot:

In account:

image

In components (default and new york):

image

In Playground, Preset selector has been updated as well #4102

image

Test cases:

343621341-a53eed18-b9f3-49ab-9a2d-87f9b928fb73

Copy link

vercel bot commented Jun 25, 2024

@manjushsh is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@manjushsh manjushsh changed the title fix(www): language selection dropdown under examples > forms > account fix(www): Landing page crash - language selection dropdown under examples > forms > account Jun 25, 2024
@manjushsh manjushsh changed the title fix(www): Landing page crash - language selection dropdown under examples > forms > account fix(www): Landing page crash due to Select/Dropdown/Combobox examples Jun 26, 2024
@manjushsh manjushsh changed the title fix(www): Landing page crash due to Select/Dropdown/Combobox examples fix(www): Fixed landing page crash (ui.shadcn.com) due to Select/Dropdown/Combobox examples Jun 26, 2024
@manjushsh
Copy link
Author

manjushsh commented Jun 29, 2024

@shadcn, Can you please review this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants