fix: correctly forward cmdk command props to the correct component #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@francois-codes is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the Command component I realised the
shouldFilterandfilteroptions couldn't be used as the exported component doesn't forward correctly these props to the underlying CommandPrimitive component that supports them.This PR fixes the issue, making sure the generated component allows the usage of these props.
Not sure about all the diffs in the lock file, I can stash them if needed.
I also ran
pnpm build:registrybut it was generating only diffs on components I hadn't modified so I figured it was probably best not to include these changesHappy to adjust what needs be in this PR so it can be merged to main.
Thanks !