-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fta-cli npm package does not currently export type defs #26
Comments
Hi, I'm looking into creating the type declarations for the npm package. I think it would make more sense to add them directly to the project. As far as I know, DefinitelyTyped ensures that types are well-commented. However, maintaining them there would be more of a hassle, as every interface change would require a new PR on DefinitelyTyped. That said, I don't expect frequent changes. I've already created the type declarations (comments are still missing): fta. |
@EcoFreshKase thanks for the contribution! Yes, it's best if the types are simply added direct to the project. You can open a PR with your changes and i'll adopt it. I don't have major changes planned so the types are likely to remain stable, but it still makes sense to have the types co-located. There is one caveat; I need to upgrade the github actions in order to get green builds and be able to release as there is currently a dependency on v2 actions that have recently been removed (see #163) |
The issue mentioned in #163 is now fixed, with the possible exception of some actions I depend on in release.yml (https://github.com/sgb-io/fta/blob/main/.github/workflows/release.yml). You should be good to submit a PR and I can merge it, then see if the release succeeds (or migrate the release actions as needed). |
@EcoFreshKase I have now upgraded most of the workflow dependencies so the project can build and release successfully again. |
No description provided.
The text was updated successfully, but these errors were encountered: