Messaging refactor #1227
Merged
Messaging refactor #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfd
force-pushed
the
paulfd/messaging-refactor
branch
6 times, most recently
from
2d516b5
to
ec3da56
Compare
Trading off complexity when parsing/replying to the messages for complexity in some templated and overloaded code blocks.
paulfd
force-pushed
the
paulfd/messaging-refactor
branch
from
ec3da56
to
857aa14
Compare
paulfd
force-pushed
the
paulfd/messaging-refactor
branch
from
c1f578b
to
b221eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to remove some of the copy pasting, at the expense of some templated/variadic code...