fixes #1768 -- integrate boringssl into the build process more naturally #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
boringssl-normal
branch
from
82d4d17
to
95a0390
Compare
|
One substantive issue I see: BoringSSL uses |
|
Should be totally fine to update -sys to the 2018 edition and just change the import to |
|
Ok! I'll endeavour to do a stand-alone PR for that. |
|
Our MSRV is at 1.56.0 so we can probably go all the way to the 2021 edition really. |
|
pyca/cryptography still has a lower MSRV (1.48 ATM), so I want to avoid creating a hard dep on 2021. |
|
If you're depending on a 1.48 MSRV then we should probably change the existing CI check (or add a new one?) to enforce that. |
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Feb 3, 2023
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Feb 3, 2023
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Feb 3, 2023
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Feb 3, 2023
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Feb 3, 2023
alex
force-pushed
the
boringssl-normal
branch
2 times, most recently
from
e6b83a3
to
84dba6e
Compare
|
This feature is now available on bindgen |
|
🎉 🎉 🎉 -- as soon as it's available in brew (Homebrew/homebrew-core#122575) I plan to rebase my boringssl CL and hopefully advance the conversation there. |
…e naturally This PR uses the in-development bindgen support for static inline functions (rust-lang/rust-bindgen#2335) + an in-development boringssl patch (https://boringssl-review.googlesource.com/c/boringssl/+/56505) to allow using boringssl with rust-openssl without needing a .cargo/config override
alex
force-pushed
the
boringssl-normal
branch
from
84dba6e
to
e4ec997
Compare
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 4, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 10, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
alex
added a commit
to alex/rust-openssl
that referenced
this pull request
Mar 10, 2023
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the in-development bindgen support for static inline functions (rust-lang/rust-bindgen#2335) + an in-development boringssl patch (https://boringssl-review.googlesource.com/c/boringssl/+/56505) to allow using boringssl with rust-openssl without needing a .cargo/config override
This is not mergable as-is (requires a bindgen release + boringssl to merge my patch), putting this up for visibility only.