rust-openssl's BoringSSL implementation of X509_OBJECT_free leaks memory

[davidben]

Not sure where this came from, but this is incorrect.

rust-openssl/openssl/src/x509/mod.rs

Line 2445 in 2d9458e

use ffi::X509_OBJECT_free_contents as X509_OBJECT_free;

If this code were ever run, it would leak memory. (Though it doesn't ever run. See #2097. You actually don't need this function at all.) I'm going to go add X509_OBJECT_free to BoringSSL, so you all should just use the ossl111 codepaths. This is all an artifact of the incorrect port to BoringSSL; see #1944.