Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hir place #19

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Move hir place #19

merged 1 commit into from
Jul 18, 2020

Conversation

arora-aman
Copy link
Member

@arora-aman arora-aman commented Jul 6, 2020 •
edited by Azhng
Loading

Needed to support rust-lang/project-rfc-2229#7

This resembles the MIR equivalent located in lbrustc_middle/mir.

This change is Reviewable

@arora-aman
Copy link
Member Author

This will let Logan/ Archer/ whoever has some time to work on rust-lang/project-rfc-2229#7

PR that Chris, Dhruv and I are working on will have some impact, nothing too bad. Hopefully Archer's PR gets merged soon and I will remove the commit from this branch then.

This builds and that should mostly be it, clippy tests passed.

Complete test suite running here: http://csclub.uwaterloo.ca/~a52arora/rust-builds/log_commit_861cfd2d0614d8bfeff70c30131a3cacb996c9e1_918a4302-c93d-4474-8291-c3f48d787aae

@arora-aman
Copy link
Member Author

Discussion relating to move the HIR Place to middle/hir: https://rust-lang.zulipchat.com/#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/Typecheck.20tables.20using.20Places/near/201773438

Azhng
Azhng approved these changes Jul 6, 2020
View reviewed changes
Copy link

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly mechanical. LGTM

arora-aman
arora-aman commented Jul 7, 2020
View reviewed changes
Copy link
Member Author

@arora-aman arora-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix docs

src/librustc_middle/hir/place.rs Outdated Show resolved Hide resolved
src/librustc_middle/hir/place.rs Outdated Show resolved Hide resolved
src/librustc_middle/hir/place.rs Outdated Show resolved Hide resolved
@arora-aman arora-aman force-pushed the move_hir_place branch 2 times, most recently from 7efc783 to c1e4eaa Compare July 8, 2020 08:00
@arora-aman @jenniferwills @logmosier
Move hir::Place to librustc_middle/hir
50f3dbd 
Needed to support rust-lang/project-rfc-2229#7

Currently rustc_typeck depends on rustc_middle for definition TypeckTables, etc.
For supporting project-rfc-2229#7, rustc_middle would've to depend on
rustc_typeck for Place -- introducing a circular dependcy.

This resembles the MIR equivalent of `Place` located in `lbrustc_middle/mir`.

Co-authored-by: Aman Arora <me@aman-arora.com>
Co-authored-by: Jennifer Wills <wills.jenniferg@gmail.com>
Co-authored-by: Logan Mosier <logmosier@gmail.com>
@arora-aman
Copy link
Member Author

Rebased and tests passed: http://csclub.uwaterloo.ca/~a52arora/rust-builds/log_06bef156-2ef2-4836-bb78-b06b0d17dde7

@arora-aman
Copy link
Member Author

rust-lang PR: rust-lang#74424

@sexxi-bot sexxi-bot merged commit 222d250 into master Jul 18, 2020
@arora-aman arora-aman deleted the move_hir_place branch July 18, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azhng Azhng Azhng approved these changes

@ChrisPardy ChrisPardy Awaiting requested review from ChrisPardy

@jenniferwills jenniferwills Awaiting requested review from jenniferwills

@logmosier logmosier Awaiting requested review from logmosier

@null-sleep null-sleep Awaiting requested review from null-sleep

@roxelo roxelo Awaiting requested review from roxelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arora-aman @Azhng @sexxi-bot