Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rustc 1.38.0-nightly (273f42b59 2019-07-21) #23822

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Upgrade to rustc 1.38.0-nightly (273f42b59 2019-07-21) #23822

merged 2 commits into from
Jul 23, 2019

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jul 22, 2019 •
edited
Loading

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 22, 2019
@SimonSapin SimonSapin mentioned this pull request Jul 22, 2019
Closed
@jdm
Copy link
Member

jdm commented Jul 22, 2019

Looks like we need to run rustfmt as well.

@jdm
Copy link
Member

jdm commented Jul 22, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 39c0a00 has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Jul 22, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 22, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 39c0a00 with merge 4470035...

bors-servo pushed a commit that referenced this pull request Jul 23, 2019
Auto merge of #23822 - servo:rustup, r=jdm
4470035 
Upgrade to rustc 1.38.0-nightly (273f42b59 2019-07-21)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23822)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 4470035 to master...

@bors-servo bors-servo merged commit 39c0a00 into master Jul 23, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 23, 2019
@tomasdivito tomasdivito mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonSapin @jdm @bors-servo @paulrouget @highfive