Make harfbuzz and harfbuzz-sys no_std #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
I assume that #231 needs to land first and then this, and given that, this looks good to me.
|
Oops, I didn't see that #231 already landed. :) |
alerque
approved these changes
Aug 25, 2023
|
@mrobinson Could this one get a stamp of approval and let it auto-merge? |
jdm
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
stdfeature, enabled by default, toharfbuzzto enable one API that needsstd::sync::Arc.