Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize package.patterns #243

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jul 16, 2021

Serverless Famework with v2.32.0 introduce an alternative to package.include and package.exclude in form of package.patterns

To avoid ambiguity support for first two will be dropped with v3, therefore it's important this plugin catches up on that.

Fixes #231
Fixes #240

@radzserg
Copy link

radzserg commented Aug 9, 2021

Nice fix. Any chance to get approve and merge this one?

@medikoo medikoo requested a review from pgrzesik August 10, 2021 12:39
@medikoo medikoo self-assigned this Aug 10, 2021
Copy link

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 👍

@medikoo medikoo merged commit 378c4f6 into serverless:master Aug 10, 2021
@medikoo medikoo deleted the 0716-fix-include-exclude-support branch August 10, 2021 13:53
@rizowski
Copy link

Could this fix be published? I am also running into this issue.

@medikoo
Copy link
Contributor Author

medikoo commented Aug 23, 2021

@rizowski we've just released it with v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants