Ensure consistent artifact sha (remove bestzip and bring back archiver)
#1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
j0k3r
force-pushed
the
serverless-zip-method
branch
from
f35818d
to
5668fcf
Compare
j0k3r
force-pushed
the
serverless-zip-method
branch
from
5668fcf
to
abf3f82
Compare
|
We tried to add e2e tests but we failed for now. |
j0k3r
force-pushed
the
serverless-zip-method
branch
from
9b59391
to
9308429
Compare
| * | ||
| * @see https://github.com/serverless/serverless/blob/63d54e1537e10ae63c171892edd886f6b81e83f6/lib/plugins/package/lib/zipService.js#L65 | ||
| */ | ||
| function serverlessZip(args) { |
There was a problem hiding this comment.
It seems the code coverage dropped because there are no unit tests for this new function.
There was a problem hiding this comment.
It's hard to test unit it, in fact, we would like to provide e2e tests which will more easy to cover that code.
j0k3r
force-pushed
the
serverless-zip-method
branch
from
9308429
to
f9c99a5
Compare
j0k3r
force-pushed
the
serverless-zip-method
branch
from
f9c99a5
to
df24200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #911
Closes #881