import, refactor, improve & yarn support #2
Conversation
| tar xzvf ./${name}.tgz -C $out --strip-components=1 | ||
| if [ "$installJavascript" = "1" ]; then | ||
| cp -R node_modules $out/ | ||
| ${ concatStringsSep ";" (map (cmd: |
There was a problem hiding this comment.
I don't know if this is every anything but npm start --scripts-prepend-node-path=true .
There was a problem hiding this comment.
What do you mean by that?
There was a problem hiding this comment.
ever*. I symlinked npm so it could run the npm start script, which is somewhat trivial to do (doesn't differ between npm and yarn, afaik)
| deps[key] = { name, resolved: url, integrity } | ||
| }) | ||
|
|
||
| console.log(JSON.stringify(deps, null, 2)) |
There was a problem hiding this comment.
Not the best way to generate non-log output.
There was a problem hiding this comment.
Why? It's less verbose than process.stdout.write(... + "\n") and does the same.
There was a problem hiding this comment.
Semantics. console.log is for logs ;)
| preInstallPhases = [ "yarnPackPhase" ]; | ||
|
|
||
| # TODO | ||
| yarnConfigPhase = '' |
There was a problem hiding this comment.
Maybe put this in preConfigurePhases?
| yarn pack --ignore-scripts --filename ${info.name}.tgz | ||
| ''; | ||
|
|
||
| installPhase = untarAndWrap info.name [npmCmd yarnCmd]; |
There was a problem hiding this comment.
I'm not sure if there's anything here that you can't do with npm.
There was a problem hiding this comment.
Maybe. I'd say it depends on the project. And how well npm works for yarn packages. For the vault ui you'd need neither npm nor yarn after building I think.
There was a problem hiding this comment.
The script running is fairly trivial and the code might even be shared between npm and yarn.
| preInstallPhases = [ "npmPackPhase" ]; | ||
|
|
||
| npmCachePhase = '' | ||
| addToSearchPath NODE_PATH ${npmModules} # pacote |
There was a problem hiding this comment.
Does this add to the final npm build search path as well?
No description provided.