Using durable seq #205
Using durable seq #205
Conversation
option to set number of days of logfiles to keep serilog-contrib#202
…ill not start before inheritade base class is finished
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| public class ElasticSearchLogShipper : LogShipper<List<string>> |
There was a problem hiding this comment.
| public class ElasticSearchLogShipper : LogShipper<List<string>> | |
| public class ElasticsearchLogShipper : LogShipper<List<string>> |
Convention is to use Elasticsearch instead of ElasticSearch
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| public class ElasticSearchPayloadReader: APayloadReader<List<string>> |
There was a problem hiding this comment.
| public class ElasticSearchPayloadReader: APayloadReader<List<string>> | |
| public class ElasticsearchPayloadReader: APayloadReader<List<string>> |
|
Thanks for your PR! Looks good. I m not actively using this sink at the moment, so it is a bit hard for me to see if this will work out fine. Adding the Seq implementation is certainly a nice go forward and the other changes look sensible. Can you also alter the thanks! |
|
Greate i will be on a vacation a week now will do it after that! |
|
I didnt know which version to use but you mentioned major version bump so i wrote 7. Please let me know if I should do something more. :) |
|
Thanks @pierresetteskog. Merged to dev so we get packages. There is another PR in progress #208 that would be nice to include in a new release. Waiting for the completion of that one to final merge to master. |
What issue does this PR address?
#179 Port buffer file improvements from Serilog.Sinks.Seq
#203 is fixed with BufferCleanPayload example can be found in Serilog.Sinks.Elasticsearch.Sample\Program.cs
#194 with BufferIndexDecider you can see the logrow and it is runned for every row see example program
#204 BufferFileCountLimit see example program
#166 SingleEventSizePostingLimit see example program
#146 fixed by using code from sink.seq
Does this PR introduce a breaking change?
No not what i know
almost no logical changes is made on the code just structural refactoring..
Other information:
code is mostly from sinks.Seq and placed in the folder Durable some classes like LogShipper PayloadReader is made generic with no dependencies to seq. Would be nice to place in some generic nuget package to share between different sinks.
Lots of settings was just working in file mode or in memory mode.
Maybe two different configure classes would be more clear.
In the example program Program.SetupLoggerWithPersistantStorage
I have tried to include all settings which is available in the persistant mode.
Sorry for the big pull request but it was a big task to move over persistant code from sink.seq.