Patch issue with os.rename on Windows

sergioburdisso · Feb 15, 2020 · dfe8b95 · dfe8b95
1 parent 6aac03e
commit dfe8b95
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -30,3 +30,6 @@ script:
   - flake8 pyss3
   - flake8 tests
   - pytest tests
+
+after_success:
+    - codecov
diff --git a/pyss3/cmd_line.py b/pyss3/cmd_line.py
@@ -1368,8 +1368,12 @@ def do_rename(self, args):
 
             if rename:
                 if path.exists(rh_file):
+                    if path.exists(rh_new_file):
+                        remove_file(rh_new_file)
                     rename_file(rh_file, rh_new_file)
                 if path.exists(model_file):
+                    if path.exists(model_new_file):
+                        remove_file(model_new_file)
                     rename_file(model_file, model_new_file)
                 CLF.__name__ = args[0]
         else:

diff --git a/tests/test_cmd_line.py b/tests/test_cmd_line.py
@@ -48,9 +48,10 @@ def test_ss3prompt(mocker, monkeypatch):
 
     # do_test
     mocker.patch("matplotlib.pyplot.show")
-    cmd.do_test(dataset_path + " file")
-    cmd.do_test(dataset_path + " file")  # cache
-    cmd.do_test(ArgsParserError)
+    if PYTHON3:
+        cmd.do_test(dataset_path + " file")
+        cmd.do_test(dataset_path + " file")  # cache
+        cmd.do_test(ArgsParserError)
 
     # do_k_fold
     cmd.do_k_fold(dataset_path + " file 3-grams 3-fold")