Fix dock layout restore (#1565) #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @tc-wleite! |
lfcnassif
approved these changes
Mar 7, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565.
I also made a few minor code changes in
Appclass, most of them to simplify code related to layout creation.Regarding to the issue itself, as the layout manager allows a lot of different configurations, the applied solution should work on any scenario, although I only tested a few of them.
In most common configurations, the "new" panels (created after the last time layout was saved) should be in locations similar to the original layout.
In the worst cases, it should still make these "new" panels visible, so the user can see them, but probably it will need to be placed in a better position by the user.