Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate a MSGViewer for MSG emails #416

Closed
lfcnassif opened this issue Mar 25, 2021 · 13 comments · Fixed by #421
Closed

Integrate a MSGViewer for MSG emails #416

lfcnassif opened this issue Mar 25, 2021 · 13 comments · Fixed by #421

Comments

@lfcnassif
Copy link
Member

Currently we have no viewer for msg and it is rendered in TextViewer. @gfd2020 implemented one a long time ago and it could be integrated. The viewer output should be coherent with MSGParser results.

@lfcnassif
Copy link
Member Author

@gfd2020 are you interested and do you have time to submit a PR with your implementation?

@gfd2020
Copy link
Collaborator

gfd2020 commented Mar 25, 2021

@gfd2020 are you interested and do you have time to submit a PR with your implementation?

Hi. I will implement.

@lfcnassif
Copy link
Member Author

Great, thank you! Take your time!

@gfd2020
Copy link
Collaborator

gfd2020 commented Mar 26, 2021

Great, thank you! Take your time!

OK! Did you see my e-mail?

@lfcnassif
Copy link
Member Author

No. Try my personal email in my profile.

@lfcnassif
Copy link
Member Author

lfcnassif commented Apr 1, 2021

Reopening, actually I had identified an issue with japanese/chinese/korean chars rendered by the viewer, when rtf-to-html library is used (most time for msg). I left it for future improvemente, but because of #435 I think we should fix this.

Possibly rtf-to-html library will need to be fixed. I was able to render chars correctly converting RTF->HTML with Tika (the code was left unused in source), but Tika removes most formatting... If you could take a look @gfd2020, that would be great.

@lfcnassif lfcnassif reopened this Apr 1, 2021
@lfcnassif
Copy link
Member Author

I can send you some samples privately if you want.

@lfcnassif lfcnassif removed their assignment Apr 2, 2021
@lfcnassif
Copy link
Member Author

I'm preparing the 3.18.6 release. This is an independent module and should not cause regressions. Should this incomplete feature be included besides the non Latin1 scripts rendering problems?

@gfd2020
Copy link
Collaborator

gfd2020 commented May 13, 2021

Reopening, actually I had identified an issue with japanese/chinese/korean chars rendered by the viewer, when rtf-to-html library is used (most time for msg). I left it for future improvemente, but because of #435 I think we should fix this.

Possibly rtf-to-html library will need to be fixed. I was able to render chars correctly converting RTF->HTML with Tika (the code was left unused in source), but Tika removes most formatting... If you could take a look @gfd2020, that would be great.

@lfcnassif - Could you send me the examples that give error?

@lfcnassif
Copy link
Member Author

@gfd2020 sent by email, thanks for taking a look.

@lfcnassif
Copy link
Member Author

lfcnassif commented Jul 13, 2021

It is not the ideal solution, but to close this I'm planning to run Tika msg decoding before rtf-to-html library. If Tika's output contains just Latin1 chars, switch to rtf-to-html library, maybe that would work. What do you think @gfd2020 ?

@gfd2020
Copy link
Collaborator

gfd2020 commented Jul 13, 2021

It is not the ideal solution, but to close this I'm planning to run Tika msg decoding before rtf-to-html library. If Tika's output contains just Latin1 chars, switch to rtf-to-html library, maybe that would work. What do you think @gfd2020 ?

I agree.

@lfcnassif
Copy link
Member Author

Will improve rendering of inline images here...

@lfcnassif lfcnassif reopened this Jul 14, 2021
lfcnassif added a commit that referenced this issue Aug 17, 2021
Conflicts:
	iped-app/src/main/java/dpf/sp/gpinf/indexer/desktop/ViewerController.java
	iped-viewers/iped-viewers-impl/pom.xml
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants