-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate a MSGViewer for MSG emails #416
Comments
@gfd2020 are you interested and do you have time to submit a PR with your implementation? |
Hi. I will implement. |
Great, thank you! Take your time! |
OK! Did you see my e-mail? |
No. Try my personal email in my profile. |
Reopening, actually I had identified an issue with japanese/chinese/korean chars rendered by the viewer, when rtf-to-html library is used (most time for msg). I left it for future improvemente, but because of #435 I think we should fix this. Possibly rtf-to-html library will need to be fixed. I was able to render chars correctly converting RTF->HTML with Tika (the code was left unused in source), but Tika removes most formatting... If you could take a look @gfd2020, that would be great. |
I can send you some samples privately if you want. |
I'm preparing the 3.18.6 release. This is an independent module and should not cause regressions. Should this incomplete feature be included besides the non Latin1 scripts rendering problems? |
@lfcnassif - Could you send me the examples that give error? |
@gfd2020 sent by email, thanks for taking a look. |
It is not the ideal solution, but to close this I'm planning to run Tika msg decoding before rtf-to-html library. If Tika's output contains just Latin1 chars, switch to rtf-to-html library, maybe that would work. What do you think @gfd2020 ? |
I agree. |
Will improve rendering of inline images here... |
Conflicts: iped-app/src/main/java/dpf/sp/gpinf/indexer/desktop/ViewerController.java iped-viewers/iped-viewers-impl/pom.xml
Currently we have no viewer for msg and it is rendered in TextViewer. @gfd2020 implemented one a long time ago and it could be integrated. The viewer output should be coherent with MSGParser results.
The text was updated successfully, but these errors were encountered: