Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock or very slow rendering with error in gallery if enableImageThumbs = false #313

Closed
lfcnassif opened this issue Nov 11, 2020 · 1 comment
Assignees
Labels

Comments

@lfcnassif
Copy link
Member

lfcnassif commented Nov 11, 2020

When image thumbs are rendered on demand in gallery (enableImageThumbs = false), if image formats not supported by java are listed (webp, svg, heic, emf...) the same fixed size thread pool is used by gallery and imagemagick converter, and that can cause very slow rendering of error images, because of "deadlock" until timeouts.

Furthermore, if more images than max Sleuthkit internal database connection pool are asked at the same time, that sometimes can deadlock in first gallery rendering. The last looks like a TSK bug, but limiting gallery thread pool size to TSK max pool size seems to workaround it.

@lfcnassif lfcnassif added the bug label Nov 11, 2020
@lfcnassif lfcnassif self-assigned this Nov 11, 2020
lfcnassif added a commit that referenced this issue Nov 11, 2020
also limit pool size to TSK max database connection pool size
@lfcnassif
Copy link
Member Author

Actually the first problem is not a deadlock, but very slow wrong rendering. When imagemagick converter times out, it returns an error "X" image and returns the thread to the pool to be reused.

Second problem seems a deadlock.

@lfcnassif lfcnassif changed the title Deadlock in gallery if enableImageThumbs = false with uncommon formats Deadlock or very slow wrong rendering in gallery if enableImageThumbs = false Nov 11, 2020
@lfcnassif lfcnassif changed the title Deadlock or very slow wrong rendering in gallery if enableImageThumbs = false Deadlock or very slow rendering with error in gallery if enableImageThumbs = false Nov 12, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant