-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load and look up ProjectVIC photoDNA hashes #280
Comments
Well, it will definitely be slower (but hopefully still very fast) and will require extra implementation effort. Just a couple of quick thoughts, not sure if they make sense at this point: |
1.1: Do you mean an external application/service to be queried? I thought about this in the past, I made it possible for tasks to accumulate items to do bulk requests to external services, so network latency will not hurt too much. There is some initial implementation in batchPythonTask branch (bad named); |
1.1. That can be another option, but I was thinking about an internal implementation. I meant more in terms of code organization. |
Basic support was implemented in #246 without photoDNA loading. Current hashset size would result in about 2GB of heap usage if we load photoDNA hashes on heap. I thought about refactoring photoDNA indexing and lookup to be disk based, but that will need some effort, and probably will be slower. Although loading on heap is not a long term solution, with current hashset size it is possible.
Any thoughts @tc-wleite ?
The text was updated successfully, but these errors were encountered: