Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to gh actions #1329

Merged
merged 2 commits into from
Jan 31, 2022
Merged

chore: migrate to gh actions #1329

merged 2 commits into from
Jan 31, 2022

Conversation

shwetha-manvinkurke
Copy link
Contributor

No description provided.

@shwetha-manvinkurke shwetha-manvinkurke marked this pull request as draft January 28, 2022 20:06
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the .codeclimate.yml file since we don't run code climate anymore?

@shwetha-manvinkurke shwetha-manvinkurke merged commit 3251610 into main Jan 31, 2022
@shwetha-manvinkurke shwetha-manvinkurke deleted the gh-actions branch January 31, 2022 22:04
Comment on lines -5 to -9
- version=6
- version=8
- version=10
- version=lts
- version=latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the SendGrid helpers that use make test-docker don't rely on the language version that's installed. They rely on the version env var which is used in their Dockerfile. The GH action needs to set the version env var since right now it will always just use lts:

ARG version=lts
FROM node:$version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants