Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge existing changes to the forked version #1

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

zach-iee
Copy link

@zach-iee zach-iee commented Jun 22, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

I'm migrating changes i've made in Soda to the forked redis-py. This should remove most of the duplicated codes in the Soda.
I'll be merging the changes to the master first and backport the changes to 4.4 and 4.5 branch later to release the custom version

This is a public repository, so i've not migrated the Soda specific codes

@zach-iee zach-iee self-assigned this Jun 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@d95d8a2). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 902935f differs from pull request most recent head 9d93769. Consider uploading reports for the commit 9d93769 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   92.22%           
=========================================
  Files             ?      116           
  Lines             ?    30252           
  Branches          ?        0           
=========================================
  Hits              ?    27899           
  Misses            ?     2353           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zach-iee zach-iee force-pushed the master_apply_to_upstream branch 2 times, most recently from 5073285 to 902935f Compare June 22, 2023 14:28
@zach-iee zach-iee marked this pull request as ready for review June 23, 2023 00:09
@zach-iee zach-iee merged commit 63e06dd into master Jun 23, 2023
@zach-iee zach-iee deleted the master_apply_to_upstream branch June 23, 2023 02:58
zach-iee added a commit that referenced this pull request Jun 23, 2023
* [GROW-2938] do not reset redis_connection on an error

* [GROW-2938] add backoff to more errors

* [GROW-2938] recover from SlotNotCoveredError

* [GROW-2938] prevent get_node_from_slot from failing due to concurrent cluster slots refresh

* [GROW-2938] add retry to ClusterPipeline

(cherry picked from commit 63e06dd)
zach-iee added a commit that referenced this pull request Jun 23, 2023
* [GROW-2938] do not reset redis_connection on an error

* [GROW-2938] add backoff to more errors

* [GROW-2938] recover from SlotNotCoveredError

* [GROW-2938] prevent get_node_from_slot from failing due to concurrent cluster slots refresh

* [GROW-2938] add retry to ClusterPipeline

(cherry picked from commit 63e06dd)
zach-iee added a commit that referenced this pull request Jun 23, 2023
* [GROW-2938] do not reset redis_connection on an error

* [GROW-2938] add backoff to more errors

* [GROW-2938] recover from SlotNotCoveredError

* [GROW-2938] prevent get_node_from_slot from failing due to concurrent cluster slots refresh

* [GROW-2938] add retry to ClusterPipeline

(cherry picked from commit 63e06dd)
@zach-iee zach-iee mentioned this pull request Jun 28, 2023
6 tasks
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Jul 7, 2023
* [GROW-2938] do not reset redis_connection on an error

* [GROW-2938] add backoff to more errors

* [GROW-2938] recover from SlotNotCoveredError

* [GROW-2938] prevent get_node_from_slot from failing due to concurrent cluster slots refresh

* [GROW-2938] add retry to ClusterPipeline

(cherry picked from commit 63e06dd)
zach-iee added a commit that referenced this pull request Jul 7, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Aug 21, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
zach-iee added a commit that referenced this pull request Aug 21, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
zach-iee added a commit that referenced this pull request Sep 14, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants