Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback when adding a patient #82

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Fix traceback when adding a patient #82

merged 2 commits into from
Sep 2, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented Sep 1, 2023

Description of the issue/feature this PR addresses

Warning

Merge senaite/senaite.core#2370 first

This PR fixes a side-effect of the portal-catalog patch introduced in senaite/senaite.core#2368

Linked issue: https://github.com/senaite/senaite.patient/issues/

Current behavior before PR

Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 385, in publish_module
  Module ZPublisher.WSGIPublisher, line 288, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module ZPublisher.WSGIPublisher, line 63, in call_object
  Module plone.z3cform.layout, line 63, in __call__
  Module plone.z3cform.layout, line 47, in update
  Module plone.dexterity.browser.add, line 138, in update
  Module plone.z3cform.fieldsets.extensible, line 65, in update
  Module plone.z3cform.patch, line 30, in GroupForm_update
  Module z3c.form.group, line 145, in update
  Module plone.app.z3cform.csrf, line 22, in execute
  Module z3c.form.action, line 98, in execute
  Module z3c.form.button, line 315, in __call__
  Module z3c.form.button, line 170, in __call__
  Module plone.dexterity.browser.add, line 116, in handleAdd
  Module z3c.form.form, line 265, in createAndAdd
  Module plone.dexterity.browser.add, line 95, in add
AttributeError: 'NoneType' object has no attribute 'id'

Desired behavior after PR is merged

No traceback, patient created correctly

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski September 1, 2023 22:35
@xispa xispa added the bug Something isn't working label Sep 1, 2023
@ramonski ramonski merged commit f32bb3b into master Sep 2, 2023
0 of 2 checks passed
@ramonski ramonski deleted the fix-add-patinet branch September 2, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants