Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget view mode #66

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Fix widget view mode #66

merged 3 commits into from
Mar 27, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR fixes the view mode of the fullname- and dob widget.

NOTE: This PR depends on senaite/senaite.core#2280

Current behavior before PR

Tracebacks occur when rendering the sample header in view mode, e.g. for an Analyst

Desired behavior after PR is merged

Fullname- and DoB widgets render correctly in view mode

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added bug Something isn't working enhancement New feature or request labels Mar 27, 2023
@ramonski ramonski requested a review from xispa March 27, 2023 14:26
@xispa xispa merged commit db92c8c into master Mar 27, 2023
@xispa xispa deleted the fix-widget-view branch March 27, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants