Fix user cannot enter future date for DateSampled when sampling workflow is enabled #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
xispa
changed the title
ramonski
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Important
Merge #2401 first
This Pull Request ensures the Date Sampled set by the user either in sample edit form or when registering a sample is within expected date interval.
Current behavior before PR
When sampling workflow is enabled, user can enter past dates in Date Sampled (while Sampling Date remains in future)
Desired behavior after PR is merged
When sampling workflow is enabled, user cannot enter past dates in Date Sampled. Likewise, when sampling workflow is disabled, user cannot enter future dates in Date Sampled.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.