Fix reference widget lookups #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s://github.com/senaite/senaite.core into fix-at-uidreference-fields-with-no-catalog-set
``` Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 385, in publish_module Module ZPublisher.WSGIPublisher, line 288, in publish Module ZPublisher.mapply, line 85, in mapply Module ZPublisher.WSGIPublisher, line 63, in call_object Module senaite.core.browser.widgets.referencewidget_search, line 29, in __call__ Module senaite.core.browser.widgets.referencewidget_search, line 73, in search Module senaite.core.browser.widgets.referencewidget_search, line 47, in get_ref_data Module senaite.core.adapters.referencewidget.dataproviders, line 105, in to_dict Module senaite.core.adapters.referencewidget.dataproviders, line 50, in lookup Module bika.lims.content.batch, line 260, in getProgress Module bika.lims.content.batch, line 242, in getAnalysisRequests Module bika.lims.content.batch, line 234, in getAnalysisRequestsBrains Module Products.CMFCore.utils, line 13, in check_getToolByName Module Products.CMFCore.utils, line 139, in getToolByName AttributeError: senaite_catalog_sample ```
Some functions from content types my rely on `aq_parent` (e.g objects that implement `IClientAware`). Current decorator unwraps acquisition from the object to extract data from, so functions that use acquisition fail ``` Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 385, in publish_module Module ZPublisher.WSGIPublisher, line 288, in publish Module ZPublisher.mapply, line 85, in mapply Module ZPublisher.WSGIPublisher, line 63, in call_object Module senaite.core.browser.widgets.referencewidget_search, line 29, in __call__ Module senaite.core.browser.widgets.referencewidget_search, line 73, in search Module senaite.core.browser.widgets.referencewidget_search, line 47, in get_ref_data Module senaite.core.adapters.referencewidget.dataproviders, line 95, in to_dict Module senaite.core.adapters.referencewidget.dataproviders, line 64, in get_base_info Module senaite.core.adapters.referencewidget.dataproviders, line 50, in lookup Module bika.lims.content.analysisrequest, line 1466, in Description AttributeError: 'AnalysisRequest' object has no attribute 'aq_parent' ```
xispa
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR fixes (and refactors) all AT reference widgets that returned no results when no query was given.
Current behavior before PR
AT reference widgets return no results if no query is given.
Desired behavior after PR is merged
AT reference widgets are refactored to ensure results are correctly returned
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.