Allow to define the sorting criteria for Result Options #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
Jun 24, 2023
IMO, Manual sorting is ok for when you have a few options only, but is not usable when you have a long list (eg. 100 or more). |
|
Ok, that makes sense. |
ramonski
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Please review and merge senaite/senaite.app.listing#107 first!
This Pull Request adds the field
ResultOptionsSortingto services and analyses, allowing the user to choose the criteria on how result options have to be sorted when a Selection, MultiSelect or MultiChoice control is rendered for results selection.Current behavior before PR
Result options are always sorted alphabetically in Select, MultiSelect and MultiChoice controls on results entry
Desired behavior after PR is merged
Result options are sorted in accordance with the criteria set by the user
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.