Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error for required fields without value in current language #2314

Merged
merged 3 commits into from
May 27, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented May 26, 2023

Description of the issue/feature this PR addresses

This Pull Request makes the system to display the error in current language when there are missing values for required fields on Sample add form. Also, displays the labels instead of field names

Current behavior before PR

System displays the error in english and field names are displayed instead of their labels

Captura de 2023-05-26 13-08-33

Desired behavior after PR is merged

System displays the error in current language and field labels are displayed instead of field_names

Captura de 2023-05-26 13-02-04

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for that one!

@ramonski ramonski merged commit bd647c1 into 2.x May 27, 2023
@ramonski ramonski deleted the sample-add-error branch May 27, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants