Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure the position of additional value columns #2272

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR is complementary to #2265 and #2266 and allows to configure the position of the interim / additional result columns in the sample/worksheet analyses listings.

Current behavior before PR

Interim columns were always placed after the result column

Desired behavior after PR is merged

The position of the interim columns can be configured over the virtual column AdditionalValues in the registry

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added Improvement 🔧 Cleanup 🧹 Code cleanup and refactoring labels Mar 11, 2023
@ramonski ramonski changed the title Allow to configure the position of the interim columns Allow to configure the position of additional value columns Mar 11, 2023
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. And the removal of my old and comprehensive, but passionate comments specially

@xispa xispa merged commit c8e7513 into 2.x Mar 11, 2023
@xispa xispa deleted the interim-column-position branch March 11, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Improvement 🔧
Development

Successfully merging this pull request may close these issues.

2 participants