Skip to content

Commit

Permalink
Remove # noqa comments (#2124)
Browse files Browse the repository at this point in the history 
* Remove # noqa from all files

* Ignore import issues in meta packages

* Remove dead code from pre_install()

* Ignore F821 for global app variable

* Remove unused import from instrument package
  • Loading branch information
@winniehell
winniehell authored Sep 20, 2022
1 parent 44914a3 commit 341f853
Show file tree
Hide file tree
Showing 42 changed files with 214 additions and 221 deletions.
20 changes: 11 additions & 9 deletions ci_flake8.cfg
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,19 @@ extend-ignore =
# W391: blank line at end of file
W391,
per-file-ignores =
# ignore import-related issues in root packages
src/bika/lims/__init__.py:E402,F401,F403
src/bika/lims/config.py:F401,F403
# ignore unused imports (F401) in meta packages
src/bika/lims/browser/worksheet/views/__init__.py:F401
src/bika/lims/browser/analyses/__init__.py:F401
src/bika/lims/browser/client/__init__.py:F401
src/bika/lims/browser/widgets/__init__.py:F401
src/bika/lims/**/__init__.py:F401
src/bika/lims/browser/analysisrequest/analysisrequests.py:F401
src/bika/lims/browser/analysisrequest/__init__.py:F401
src/bika/lims/subscribers/__init__.py:F401
src/bika/lims/interfaces/__init__.py:F401
src/senaite/core/exportimport/instruments/__init__.py:F401
src/senaite/core/behaviors/__init__.py:F401
src/bika/lims/browser/dashboard/dashboard.py:F401
src/bika/lims/browser/widgets/*widget.py:F401
src/bika/lims/catalog/*_catalog.py:F401
src/senaite/core/**/__init__.py:F401
# ignore "import *" (F401, F403) in meta packages
src/bika/lims/browser/viewlets/__init__.py:F401,F403
src/senaite/core/interfaces/__init__.py:F401,F403
# ignore "import *" (F403, F405) in Archetypes models
src/bika/lims/content/*.py:F403,F405
# Zope scripts are only function bodies (see https://zope.readthedocs.io/en/latest/zopebook/BasicScripting.html)
Expand Down
198 changes: 99 additions & 99 deletions src/bika/lims/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,109 +46,109 @@

# Implicit module imports used by others
# XXX Refactor these dependencies to explicit imports!
from bika.lims.config import * # noqa
# from bika.lims.permissions import * # noqa
from bika.lims.validators import * # noqa
from Products.Archetypes import PloneMessageFactory as PMF # noqa
from bika.lims.config import *
# from bika.lims.permissions import *
from bika.lims.validators import *
from Products.Archetypes import PloneMessageFactory as PMF


def initialize(context):
logger.info("*** Initializing BIKA.LIMS ***")
from bika.lims.content.analysis import Analysis # noqa
from bika.lims.content.analysiscategory import AnalysisCategory # noqa
from bika.lims.content.analysisprofile import AnalysisProfile # noqa
from bika.lims.content.analysisrequest import AnalysisRequest # noqa
from bika.lims.content.analysisrequestsfolder import AnalysisRequestsFolder # noqa
from bika.lims.content.analysisservice import AnalysisService # noqa
from bika.lims.content.analysisspec import AnalysisSpec # noqa
from bika.lims.content.arreport import ARReport # noqa
from bika.lims.content.artemplate import ARTemplate # noqa
from bika.lims.content.attachment import Attachment # noqa
from bika.lims.content.attachmenttype import AttachmentType # noqa
from bika.lims.content.autoimportlog import AutoImportLog # noqa
from bika.lims.content.batch import Batch # noqa
from bika.lims.content.batchfolder import BatchFolder # noqa
from bika.lims.content.batchlabel import BatchLabel # noqa
from bika.lims.content.bikaschema import BikaSchema # noqa
from bika.lims.content.bikasetup import BikaSetup # noqa
from bika.lims.content.calculation import Calculation # noqa
from bika.lims.content.client import Client # noqa
from bika.lims.content.clientfolder import ClientFolder # noqa
from bika.lims.content.contact import Contact # noqa
from bika.lims.content.container import Container # noqa
from bika.lims.content.containertype import ContainerType # noqa
from bika.lims.content.department import Department # noqa
from bika.lims.content.duplicateanalysis import DuplicateAnalysis # noqa
from bika.lims.content.instrument import Instrument # noqa
from bika.lims.content.instrumentcalibration import InstrumentCalibration # noqa
from bika.lims.content.instrumentcertification import InstrumentCertification # noqa
from bika.lims.content.instrumentlocation import InstrumentLocation # noqa
from bika.lims.content.instrumentmaintenancetask import InstrumentMaintenanceTask # noqa
from bika.lims.content.instrumentscheduledtask import InstrumentScheduledTask # noqa
from bika.lims.content.instrumenttype import InstrumentType # noqa
from bika.lims.content.instrumentvalidation import InstrumentValidation # noqa
from bika.lims.content.invoice import Invoice # noqa
from bika.lims.content.labcontact import LabContact # noqa
from bika.lims.content.laboratory import Laboratory # noqa
from bika.lims.content.labproduct import LabProduct # noqa
from bika.lims.content.manufacturer import Manufacturer # noqa
from bika.lims.content.method import Method # noqa
from bika.lims.content.methods import Methods # noqa
from bika.lims.content.multifile import Multifile # noqa
from bika.lims.content.organisation import Organisation # noqa
from bika.lims.content.person import Person # noqa
from bika.lims.content.preservation import Preservation # noqa
from bika.lims.content.pricelist import Pricelist # noqa
from bika.lims.content.pricelistfolder import PricelistFolder # noqa
from bika.lims.content.referenceanalysis import ReferenceAnalysis # noqa
from bika.lims.content.referencedefinition import ReferenceDefinition # noqa
from bika.lims.content.referencesample import ReferenceSample # noqa
from bika.lims.content.referencesamplesfolder import ReferenceSamplesFolder # noqa
from bika.lims.content.rejectanalysis import RejectAnalysis # noqa
from bika.lims.content.report import Report # noqa
from bika.lims.content.reportfolder import ReportFolder # noqa
from bika.lims.content.samplecondition import SampleCondition # noqa
from bika.lims.content.samplematrix import SampleMatrix # noqa
from bika.lims.content.samplepoint import SamplePoint # noqa
from bika.lims.content.sampletype import SampleType # noqa
from bika.lims.content.samplingdeviation import SamplingDeviation # noqa
from bika.lims.content.storagelocation import StorageLocation # noqa
from bika.lims.content.subgroup import SubGroup # noqa
from bika.lims.content.supplier import Supplier # noqa
from bika.lims.content.suppliercontact import SupplierContact # noqa
from bika.lims.content.worksheet import Worksheet # noqa
from bika.lims.content.worksheetfolder import WorksheetFolder # noqa
from bika.lims.content.worksheettemplate import WorksheetTemplate # noqa

from bika.lims.controlpanel.auditlog import AuditLog # noqa
from bika.lims.controlpanel.bika_analysiscategories import AnalysisCategories # noqa
from bika.lims.controlpanel.bika_analysisprofiles import AnalysisProfiles # noqa
from bika.lims.controlpanel.bika_analysisservices import AnalysisServices # noqa
from bika.lims.controlpanel.bika_analysisspecs import AnalysisSpecs # noqa
from bika.lims.controlpanel.bika_artemplates import ARTemplates # noqa
from bika.lims.controlpanel.bika_attachmenttypes import AttachmentTypes # noqa
from bika.lims.controlpanel.bika_batchlabels import BatchLabels # noqa
from bika.lims.controlpanel.bika_calculations import Calculations # noqa
from bika.lims.controlpanel.bika_containers import Containers # noqa
from bika.lims.controlpanel.bika_containertypes import ContainerTypes # noqa
from bika.lims.controlpanel.bika_departments import Departments # noqa
from bika.lims.controlpanel.bika_instrumentlocations import InstrumentLocations # noqa
from bika.lims.controlpanel.bika_instruments import Instruments # noqa
from bika.lims.controlpanel.bika_instrumenttypes import InstrumentTypes # noqa
from bika.lims.controlpanel.bika_labcontacts import LabContacts # noqa
from bika.lims.controlpanel.bika_labproducts import LabProducts # noqa
from bika.lims.controlpanel.bika_manufacturers import Manufacturers # noqa
from bika.lims.controlpanel.bika_preservations import Preservations # noqa
from bika.lims.controlpanel.bika_referencedefinitions import ReferenceDefinitions # noqa
from bika.lims.controlpanel.bika_sampleconditions import SampleConditions # noqa
from bika.lims.controlpanel.bika_samplematrices import SampleMatrices # noqa
from bika.lims.controlpanel.bika_samplepoints import SamplePoints # noqa
from bika.lims.controlpanel.bika_sampletypes import SampleTypes # noqa
from bika.lims.controlpanel.bika_samplingdeviations import SamplingDeviations # noqa
from bika.lims.controlpanel.bika_storagelocations import StorageLocations # noqa
from bika.lims.controlpanel.bika_subgroups import SubGroups # noqa
from bika.lims.controlpanel.bika_suppliers import Suppliers # noqa
from bika.lims.controlpanel.bika_worksheettemplates import WorksheetTemplates # noqa
from bika.lims.content.analysis import Analysis
from bika.lims.content.analysiscategory import AnalysisCategory
from bika.lims.content.analysisprofile import AnalysisProfile
from bika.lims.content.analysisrequest import AnalysisRequest
from bika.lims.content.analysisrequestsfolder import AnalysisRequestsFolder
from bika.lims.content.analysisservice import AnalysisService
from bika.lims.content.analysisspec import AnalysisSpec
from bika.lims.content.arreport import ARReport
from bika.lims.content.artemplate import ARTemplate
from bika.lims.content.attachment import Attachment
from bika.lims.content.attachmenttype import AttachmentType
from bika.lims.content.autoimportlog import AutoImportLog
from bika.lims.content.batch import Batch
from bika.lims.content.batchfolder import BatchFolder
from bika.lims.content.batchlabel import BatchLabel
from bika.lims.content.bikaschema import BikaSchema
from bika.lims.content.bikasetup import BikaSetup
from bika.lims.content.calculation import Calculation
from bika.lims.content.client import Client
from bika.lims.content.clientfolder import ClientFolder
from bika.lims.content.contact import Contact
from bika.lims.content.container import Container
from bika.lims.content.containertype import ContainerType
from bika.lims.content.department import Department
from bika.lims.content.duplicateanalysis import DuplicateAnalysis
from bika.lims.content.instrument import Instrument
from bika.lims.content.instrumentcalibration import InstrumentCalibration
from bika.lims.content.instrumentcertification import InstrumentCertification
from bika.lims.content.instrumentlocation import InstrumentLocation
from bika.lims.content.instrumentmaintenancetask import InstrumentMaintenanceTask
from bika.lims.content.instrumentscheduledtask import InstrumentScheduledTask
from bika.lims.content.instrumenttype import InstrumentType
from bika.lims.content.instrumentvalidation import InstrumentValidation
from bika.lims.content.invoice import Invoice
from bika.lims.content.labcontact import LabContact
from bika.lims.content.laboratory import Laboratory
from bika.lims.content.labproduct import LabProduct
from bika.lims.content.manufacturer import Manufacturer
from bika.lims.content.method import Method
from bika.lims.content.methods import Methods
from bika.lims.content.multifile import Multifile
from bika.lims.content.organisation import Organisation
from bika.lims.content.person import Person
from bika.lims.content.preservation import Preservation
from bika.lims.content.pricelist import Pricelist
from bika.lims.content.pricelistfolder import PricelistFolder
from bika.lims.content.referenceanalysis import ReferenceAnalysis
from bika.lims.content.referencedefinition import ReferenceDefinition
from bika.lims.content.referencesample import ReferenceSample
from bika.lims.content.referencesamplesfolder import ReferenceSamplesFolder
from bika.lims.content.rejectanalysis import RejectAnalysis
from bika.lims.content.report import Report
from bika.lims.content.reportfolder import ReportFolder
from bika.lims.content.samplecondition import SampleCondition
from bika.lims.content.samplematrix import SampleMatrix
from bika.lims.content.samplepoint import SamplePoint
from bika.lims.content.sampletype import SampleType
from bika.lims.content.samplingdeviation import SamplingDeviation
from bika.lims.content.storagelocation import StorageLocation
from bika.lims.content.subgroup import SubGroup
from bika.lims.content.supplier import Supplier
from bika.lims.content.suppliercontact import SupplierContact
from bika.lims.content.worksheet import Worksheet
from bika.lims.content.worksheetfolder import WorksheetFolder
from bika.lims.content.worksheettemplate import WorksheetTemplate

from bika.lims.controlpanel.auditlog import AuditLog
from bika.lims.controlpanel.bika_analysiscategories import AnalysisCategories
from bika.lims.controlpanel.bika_analysisprofiles import AnalysisProfiles
from bika.lims.controlpanel.bika_analysisservices import AnalysisServices
from bika.lims.controlpanel.bika_analysisspecs import AnalysisSpecs
from bika.lims.controlpanel.bika_artemplates import ARTemplates
from bika.lims.controlpanel.bika_attachmenttypes import AttachmentTypes
from bika.lims.controlpanel.bika_batchlabels import BatchLabels
from bika.lims.controlpanel.bika_calculations import Calculations
from bika.lims.controlpanel.bika_containers import Containers
from bika.lims.controlpanel.bika_containertypes import ContainerTypes
from bika.lims.controlpanel.bika_departments import Departments
from bika.lims.controlpanel.bika_instrumentlocations import InstrumentLocations
from bika.lims.controlpanel.bika_instruments import Instruments
from bika.lims.controlpanel.bika_instrumenttypes import InstrumentTypes
from bika.lims.controlpanel.bika_labcontacts import LabContacts
from bika.lims.controlpanel.bika_labproducts import LabProducts
from bika.lims.controlpanel.bika_manufacturers import Manufacturers
from bika.lims.controlpanel.bika_preservations import Preservations
from bika.lims.controlpanel.bika_referencedefinitions import ReferenceDefinitions
from bika.lims.controlpanel.bika_sampleconditions import SampleConditions
from bika.lims.controlpanel.bika_samplematrices import SampleMatrices
from bika.lims.controlpanel.bika_samplepoints import SamplePoints
from bika.lims.controlpanel.bika_sampletypes import SampleTypes
from bika.lims.controlpanel.bika_samplingdeviations import SamplingDeviations
from bika.lims.controlpanel.bika_storagelocations import StorageLocations
from bika.lims.controlpanel.bika_subgroups import SubGroups
from bika.lims.controlpanel.bika_suppliers import Suppliers
from bika.lims.controlpanel.bika_worksheettemplates import WorksheetTemplates

from bika.lims import permissions
from senaite.core import permissions as core_permissions
Expand Down
2 changes: 1 addition & 1 deletion src/bika/lims/api/snapshot.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def get_request_data(request=None):
:param request: Request object
:returns: Dictionary of extracted request header/form data
""" # noqa
"""

if request is None:
# get the request
Expand Down
2 changes: 1 addition & 1 deletion src/bika/lims/browser/contact.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from bika.lims.browser import BrowserView
from bika.lims.content.contact import Contact
from bika.lims.content.labcontact import LabContact
from Products.CMFPlone.controlpanel.browser.usergroups_usersoverview import UsersOverviewControlPanel # noqa
from Products.CMFPlone.controlpanel.browser.usergroups_usersoverview import UsersOverviewControlPanel
from plone.memoize import view
from plone.protect import CheckAuthenticator
from Products.CMFCore.utils import getToolByName
Expand Down
2 changes: 1 addition & 1 deletion src/bika/lims/browser/dashboard/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
# Some rights reserved, see README and LICENSE.

# BBB
from senaite.core.browser.dashboard.dashboard import DashboardView # noqa
from senaite.core.browser.dashboard.dashboard import DashboardView
4 changes: 2 additions & 2 deletions src/bika/lims/browser/dashboard/dashboard.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@
# Some rights reserved, see README and LICENSE.

# BBB
from senaite.core.browser.dashboard.dashboard import DashboardView # noqa
from senaite.core.browser.dashboard.dashboard import setup_dashboard_panels_visibility_registry # noqa
from senaite.core.browser.dashboard.dashboard import DashboardView
from senaite.core.browser.dashboard.dashboard import setup_dashboard_panels_visibility_registry
24 changes: 12 additions & 12 deletions src/bika/lims/browser/fields/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
# Copyright 2018-2021 by it's authors.
# Some rights reserved, see README and LICENSE.

from .addressfield import AddressField # noqa
from .aranalysesfield import ARAnalysesField # noqa
from .coordinatefield import CoordinateField # noqa
from .durationfield import DurationField # noqa
from .emailsfield import EmailsField # noqa
from .historyawarereferencefield import HistoryAwareReferenceField # noqa
from .interimfieldsfield import InterimFieldsField # noqa
from .partitionsetupfield import PartitionSetupField # noqa
from .referenceresultsfield import ReferenceResultsField # noqa
from .resultrangefield import ResultRangeField # noqa
from .resultsrangesfield import ResultsRangesField # noqa
from .uidreferencefield import UIDReferenceField # noqa
from .addressfield import AddressField
from .aranalysesfield import ARAnalysesField
from .coordinatefield import CoordinateField
from .durationfield import DurationField
from .emailsfield import EmailsField
from .historyawarereferencefield import HistoryAwareReferenceField
from .interimfieldsfield import InterimFieldsField
from .partitionsetupfield import PartitionSetupField
from .referenceresultsfield import ReferenceResultsField
from .resultrangefield import ResultRangeField
from .resultsrangesfield import ResultsRangesField
from .uidreferencefield import UIDReferenceField
2 changes: 1 addition & 1 deletion src/bika/lims/browser/fields/remarksfield.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def _parse_legacy_remarks(self, text):

# split legacy remarks on the complete delimiter, e.g.:
# === Tue, 28 Jan 2020 06:53:58 +0100 (admin)\nThis is a Test
lines = re.split(r"(===) ([A-Za-z]{3}, \d{1,2} [A-Za-z]{3} \d{2,4} \d{2}:\d{2}:\d{2} [+-]{1}\d{4}) \((.*?)\)", text) # noqa
lines = re.split(r"(===) ([A-Za-z]{3}, \d{1,2} [A-Za-z]{3} \d{2,4} \d{2}:\d{2}:\d{2} [+-]{1}\d{4}) \((.*?)\)", text)

record = None
records = []
Expand Down
1 change: 0 additions & 1 deletion src/bika/lims/browser/instrument.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
from bika.lims.browser.bika_listing import BikaListingView
from bika.lims.browser.chart.analyses import EvolutionChart
from bika.lims.browser.resultsimport.autoimportlogs import AutoImportLogsView
from bika.lims.browser.viewlets import InstrumentQCFailuresViewlet # noqa
from bika.lims.content.instrumentmaintenancetask import \
InstrumentMaintenanceTaskStatuses as mstatus
from bika.lims.utils import get_image
Expand Down
4 changes: 2 additions & 2 deletions src/bika/lims/browser/viewlets/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@
# Copyright 2018-2021 by it's authors.
# Some rights reserved, see README and LICENSE.

from analysisrequest import * # noqa
from instruments import InstrumentQCFailuresViewlet # noqa
from analysisrequest import *
from instruments import InstrumentQCFailuresViewlet
2 changes: 1 addition & 1 deletion src/bika/lims/browser/widgets/datetimewidget.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
# Copyright 2018-2021 by it's authors.
# Some rights reserved, see README and LICENSE.

from senaite.core.browser.widgets.datetimewidget import DateTimeWidget # noqa
from senaite.core.browser.widgets.datetimewidget import DateTimeWidget
2 changes: 1 addition & 1 deletion src/bika/lims/browser/widgets/durationwidget.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
# Copyright 2018-2021 by it's authors.
# Some rights reserved, see README and LICENSE.

from senaite.core.browser.widgets.durationwidget import DurationWidget # noqa
from senaite.core.browser.widgets.durationwidget import DurationWidget
2 changes: 1 addition & 1 deletion src/bika/lims/browser/widgets/recordswidget.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
# Copyright 2018-2021 by it's authors.
# Some rights reserved, see README and LICENSE.

from senaite.core.browser.widgets.recordswidget import RecordsWidget # noqa
from senaite.core.browser.widgets.recordswidget import RecordsWidget
Loading

0 comments on commit 341f853

Please sign in to comment.