Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow to "submit" AST analyses with no result saved #25

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented Jun 21, 2023

Description of the issue/feature this PR addresses

This Pull Request ensures that user cannot submit AST analyses without result for all antibiotics being set.

Current behavior before PR

User can submit sensitivity results with missing values for antibiotics:

Captura de 2023-06-21 13-20-23

Desired behavior after PR is merged

User cannot submit sensitivity results with missing values for antibiotics

Captura de 2023-06-21 13-24-15

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski merged commit d7d11b5 into master Jun 21, 2023
@ramonski ramonski deleted the no-submit-empties branch June 21, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants