Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default values for multi-choices type #137

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

xispa
Copy link
Member

@xispa xispa commented Nov 7, 2023

Description of the issue/feature this PR addresses

This Pull Request ensures that default values for multi-choice interim fields are considered, regardless of being numeric or string

See senaite/senaite.core#2414 (review) and senaite/senaite.core#2414 (comment)

Current behavior before PR

Default values for multi-choices are only considered when default values are expressed as strings

Desired behavior after PR is merged

Default values for multi-choices are always considered, even when expressed as numbers

Captura de 2023-11-07 18-42-04
Captura de 2023-11-07 18-41-47

--
I confirm I have tested the PR thoroughly and coded it according to PEP8
standards.

@xispa xispa requested a review from ramonski November 7, 2023 17:52
@ramonski ramonski merged commit 57d8e06 into 2.x Nov 7, 2023
@ramonski ramonski deleted the default-multichoices branch November 7, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants