test(login): claim | which always false

semaphoreui · Mar 24, 2024 · 2457cbc · 2457cbc
1 parent f982f3d
commit 2457cbc
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/api/login.go b/api/login.go
@@ -431,6 +431,10 @@ func parseClaim(str string, claims map[string]interface{}) (string, bool) {
 	for _, s := range strings.Split(str, "|") {
 		s = strings.TrimSpace(s)
 
+		if s == "" {
+			continue
+		}
+
 		if strings.Contains(s, "{{") {
 			tpl, err := template.New("").Parse(s)
 

diff --git a/api/login_test.go b/api/login_test.go
@@ -53,3 +53,17 @@ func TestParseClaim3(t *testing.T) {
 		t.Fail()
 	}
 }
+
+func TestParseClaim4(t *testing.T) {
+	claims := map[string]interface{}{
+		"username": "fiftin",
+		"email":    "",
+		"id":       1234567,
+	}
+
+	_, ok := parseClaim("|", claims)
+
+	if ok {
+		t.Fail()
+	}
+}