-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error handling and debug information with configuration files that are empty, or not present. #2155
Open
EvanCarroll
wants to merge
11
commits into
semantic-release:master
Choose a base branch
from
EvanCarroll:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanCarroll
changed the title
Closes out #2152
Fix error handling and debug information with configuration files that are empty, or not present.
Sep 28, 2021
Previously we only showed the configuration options merged with defaults and after post-processing.
This was covered in semantic-release#1696. This is an attempt to resolve all outstanding known issues between ci and noCi from command line and env.
Previously we only showed the configuration options merged with defaults and after post-processing.
* Make a loud debug message if there is no configuration file found * Throw an error if there is a configuration file but it is empty. This can happen if you misspell modules.exports as module.export and you use a .js file.
Now this should look at the URL from the CI ENV vars
Fixes GH semantic-release#2155 * Make a loud debug message if there is no configuration file found * Throw an error if there is a configuration file but it is empty. This can happen if you misspell modules.exports as module.export and you use a .js file.
Fixes GH semantic-release#2050. This feature is awesomely silly. So disable unless `ENV["SCRUB"]` is set.
GITLAB_TOKEN, if present, will have great access rights to the repository. Semantic-Release needs to be able to push tags.
I believe the call to format was messing things up and causing an undef error. This is cleaner, and works better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things.
Now if you have on config file you'll see the unthrown
ECONFIGNOTFOUND
error in your log:The debug information no longer just shows the merged stuff, but also what the config file had in it. This is very useful if your config file is CommonJS and fixes #2152
And there is a new fatal Error that is throw if the file exists but it's empty
EEMPTYCONFIG