Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): lock file maintenance #255

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2023

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@gr2m
Copy link
Member

gr2m commented Jul 2, 2023

see bcoe/c8#478 and istanbuljs/istanbuljs#725. All listed packages seem to be unaffected. Not sure if we can set exceptions so we don't get blocked by it? Or if that's even a good idea to do

@renovate
Copy link
Contributor Author

renovate bot commented Jul 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@travi
Copy link
Member

travi commented Jul 3, 2023

All listed packages seem to be unaffected. Not sure if we can set exceptions so we don't get blocked by it? Or if that's even a good idea to do

hmm, this failure isnt even the intent of that npm audit signatures check. the goal is to verify signatures and provenance, not check for vulnerabilities. in older versions of npm, the signatures sub command didnt exist and unknown subcommands are ignored by the npm cli. i think that is likely what is going on here, i bet it doesnt recognize signatures and is falling back to a simple npm audit

@travi
Copy link
Member

travi commented Jul 3, 2023

confirmed. looks like node v18.0.0 includes v8.6.0 of the npm cli, but the audit signatures command was added to the npm cli in v18.14.0.

rather than running this command in all versions of our verification matrix, we could run it in the job that runs against lts/*. looks like we already do that in other repos.

@travi
Copy link
Member

travi commented Jul 3, 2023

rather than running this command in all versions of our verification matrix, we could run it in the job that runs against lts/*. looks like we already do that in other repos.

updated in 272c67e

@travi travi merged commit b0a6800 into master Jul 3, 2023
9 checks passed
@travi travi deleted the renovate/lock-file-maintenance branch July 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants