enable errorlint linter and fix issues #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicbarnes
force-pushed
the
moar-error-handling
branch
from
2279df7
to
e61c6a7
Compare
dominicbarnes
force-pushed
the
moar-error-handling
branch
from
e61c6a7
to
abce88e
Compare
dominicbarnes
force-pushed
the
moar-error-handling
branch
from
8c22b7c
to
abf5a3c
Compare
dominicbarnes
force-pushed
the
moar-error-handling
branch
from
abf5a3c
to
85dc24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the errorlint linter in golangci-lint. This specifically ensures that errors are properly checked, avoiding things like direct equality (
==) checks and type coercion/switch, to ensure as much compatibility with improvements to errors in go 1.13+.This is a continuation of #877, but will need to be followed up by one more PR to enable another linter to ensure we wrap errors coming from external packages.