-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do a final commit on end consumer group generation for immediate commits #715
Conversation
Possible related to #772 |
Good call. This definitely could be related since they are not setting the |
From https://docs.confluent.io/platform/current/clients/consumer.html
Sounds like this would be a nice addition to the Reader. @stevevls Are you interested in continuing this PR and adding test? If not I could give it a crack. |
If this PR is not ready for review might make sense to make it a Draft PR. @rhansen2 I think this makes sense for you to take over since it's been several days. |
1cdbde1
to
0ddaf4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
Thanks for landing this team! 🙌 I'm sorry I didn't see the mention for whether I wanted to keep working on it. |
This is a WIP and isn't ready to commit until I put a unit test together. 😄
This PR adds a final commit upon exiting the consumer group when using the synchronous commit mode. Otherwise, it's possible that we lose commits on generation end (or other events that initiate the end of a generation such as closing the reader).
Fixes #711