Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve AST parsing error in Jupyter Notebook #736

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

KeertiX
Copy link
Contributor

@KeertiX KeertiX commented Feb 16, 2023

ISSUE :

STEPS TO REPRODUCE :

FIX DESCRIPTION / SUMMARY OF CHANGES

  1. Refactor Flowgraph related functionality (graph and steps creation) to InspectFlow()
    Rationale: There is no need to create the graph and steps in MetaflowInterface and these steps can be performed only
    if the user desires to generate FlowGraph

  2. Fetch the source code of flow instead of module in FlowGraph()
    Rationale: Only flow source code is required for generation of Graph. 
    Understanding is that this change should also obviate the need to reload the module as it should always fetch the
    updated source code for the flow

VERIFICATION SUMMARY:

Verified if the fix is working in Google colab, Jupyter notebook and python file

  • Add bug in any of the jupyter notebook cell/google colab/py file and run.
  • Fix the issue and rerun the cell till flflow.run to verify whether its throwing AST error
  • For supported flows, verified that graph html is generated properly

Closes #724

@KeertiX KeertiX changed the title Fixed module reload Resolve AST parsing error in Jupyter Notebook Feb 16, 2023
Signed-off-by: Keerti Talwar <keertix.talwar@intel.com>
Signed-off-by: Keerti Talwar <keertix.talwar@intel.com>
@KeertiX KeertiX marked this pull request as draft February 17, 2023 12:25
@KeertiX KeertiX marked this pull request as ready for review February 17, 2023 12:25
@KeertiX KeertiX marked this pull request as draft February 20, 2023 07:07
@KeertiX KeertiX marked this pull request as ready for review February 20, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow Interface: AST parsing error can arise in jupyter notebooks
1 participant