Add tag name argument to graminize #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DL8
force-pushed
the
graminize-tag-name
branch
2 times, most recently
from
ef736cd
to
fb75849
Compare
DL8
force-pushed
the
graminize-tag-name
branch
2 times, most recently
from
da97606
to
08cc9a9
Compare
DL8
force-pushed
the
graminize-tag-name
branch
2 times, most recently
from
df5cd13
to
9e1f899
Compare
openfl/interface/workspace.py
Outdated
| @@ -443,6 +443,11 @@ def dockerize_(context, base_image, save): | |||
| 'Must be a power-of-2.\n' | |||
| 'Default is 16G.' | |||
| ) | |||
| @option('-t', '--tag', required=False, | |||
| type=str, multiple=False, default=None, | |||
There was a problem hiding this comment.
Suggested change
| type=str, multiple=False, default=None, | |
| type=str, multiple=False, default='', |
openfl/interface/workspace.py
Outdated
| @@ -501,6 +506,10 @@ def open_pipe(command: str): | |||
|
|
|||
| workspace_path = Path.cwd() | |||
| workspace_name = workspace_path.name | |||
|
|
|||
| if tag is None: | |||
There was a problem hiding this comment.
Suggested change
| if tag is None: | |
| if not tag: |
Allow seting the image tag in "fx workspace graminize" using the "-t" argument. When set, it will be used instead of the workspace name Docker image tag and archive file name Signed-off-by: Lavi, Nir <nir.lavi@intel.com>
DL8
force-pushed
the
graminize-tag-name
branch
from
34b3d19
to
9808dc7
Compare
itrushkin
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the graminized image name in "fx workspace graminize" using the "-t" argument. The tag name is formatted with the "worspace_name" input, such that "{workspace_name}" format specifier in the tag name will be replace by the workspace name
If not specified, the workspace name will be used as tag (current behavior)
Signed-off-by: Lavi, Nir nir.lavi@intel.com