Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic PR labels #3

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Add automatic PR labels #3

merged 1 commit into from
Nov 18, 2022

Conversation

bennettgoble
Copy link
Member

Automatically label PRs with a handful of code-area based groups.

@nat-goodspeed
Copy link
Collaborator

Please explain in a bit more detail what this accomplishes?

- indra/llwindow/**/*

llxml:
- indra/llxml/**/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woof, my impulse here is to commit a script that will generate (most of) the labeler.yaml file, possibly appending the lines below from, say, a labeler.yaml.in file. This is a file I will certainly forget to modify if in future I add a new indra subdirectory.

That said, we don't need to block this PR waiting for that.

@Nicky-D
Copy link
Contributor

Nicky-D commented Nov 18, 2022

There is directories missing. At least

  • media_plugin/
  • win_crash_logger
  • linux_crash_logger

maybe some more. Is this intended?

@bennettgoble
Copy link
Member Author

There is directories missing. At least
maybe some more. Is this intended?

Yes, this is a fast first pass. More can be added as appropriate as a follow-up.

@bennettgoble
Copy link
Member Author

Please explain in a bit more detail what this accomplishes?

This change will result in PRs receiving a set of automatic labels based on the files that have been changed. This is useful for sifting through PRs after dozens/hundreds/thousands have been merged.

@bennettgoble bennettgoble merged commit f7f163f into master Nov 18, 2022
@bennettgoble bennettgoble deleted the signal/label branch November 18, 2022 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
akleshchev added a commit that referenced this pull request Oct 26, 2023
akleshchev added a commit that referenced this pull request Oct 26, 2023
akleshchev added a commit that referenced this pull request Oct 26, 2023
akleshchev added a commit that referenced this pull request Jan 29, 2024
Fix dialog box being blank in task bar
akleshchev added a commit that referenced this pull request Jan 29, 2024
Fix dialog box being blank in task bar
akleshchev added a commit that referenced this pull request Jan 29, 2024
Fix dialog box being blank in task bar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants