#459 Filters on object inventory #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Sep 5, 2024
akleshchev
approved these changes
Sep 5, 2024
LLGuru
force-pushed
the
guru/viewer-2459-filters-on-object-inventory
branch
from
ead1d0c
to
7e8bc8b
Compare
marchcat
reviewed
Sep 6, 2024
indra/newview/llinventoryfilter.cpp
Outdated
| @@ -47,7 +47,7 @@ | |||
| // linden library includes | |||
| #include "llclipboard.h" | |||
| #include "lltrans.h" | |||
|
|
|||
| #pragma optimize("", off) | |||
LLGuru
force-pushed
the
guru/viewer-2459-filters-on-object-inventory
branch
from
7e8bc8b
to
a3d37ca
Compare
marchcat
approved these changes
Sep 6, 2024
LLGuru
force-pushed
the
guru/viewer-2459-filters-on-object-inventory
branch
from
a3d37ca
to
166c782
Compare
LLGuru
force-pushed
the
guru/viewer-2459-filters-on-object-inventory
branch
from
166c782
to
da46027
Compare
akleshchev
reviewed
Sep 9, 2024
| std::shared_ptr<LLMoveInv> move_inv(new LLMoveInv); | ||
| move_inv->mObjectID = object_id; | ||
| move_inv->mCategoryID = category_id; | ||
| move_inv->mCallback = callback; | ||
| move_inv->mUserData = user_data; | ||
|
|
||
| for ( ; it != end; ++it) | ||
| for (LLPointer<LLInventoryObject> obj : inventory_objects) |
There was a problem hiding this comment.
this should have been a reference
akleshchev
reviewed
Sep 9, 2024
| return false; | ||
|
|
||
| if (!isAgentAvatarValid()) | ||
| return false; |
There was a problem hiding this comment.
Why does this need to check isAgentAvatarValid()?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter editor looks like follows
