Incremented viewer version after release/2024.08-DeltaFPS branch creation #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Aug 20, 2024
To make sure I understand: I think you mean right after creating a new release branch from develop? Or do you mean "freezing" in the sense of no additional changes, just before promoting? From context, I think the former. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm considering trying something new here for the new git-flow process. since release branches now try to avoid merging from main when a viewer is promoted (as they should already contain all the relevant changes by way of them being in develop as well). it seems that the right time to increment the viewer version is immediately after freezing a new release branch. that way nightly builds of develop will now have an incremented version number from that point onward.